Skip Navigation

Posts
4
Comments
246
Joined
3 yr. ago

  • You can (and should) just use a password manager to generate and store ~64 byte keys which have roughly the same amount of security.

  • Deleted

    Permanently Deleted

    Jump
  • You should probably go back because there are usually two tubes to cut. (/s)

  • Deleted

    Permanently Deleted

    Jump
  • When someone says "I'm going to the bathroom" they are not guilty of forcing you to visualise them shitting.

  • If you do a port scan on your box, what services are running? Maybe something like email or diagnostics is exposed to the internet and announcing subdomains?

  • I actually just Googled (well, Kagi'd) it, and found the article that the AI presumably hallucinated this command from.

  • Sounds like a good way to remove the French language pack from your system. :P

  • The command it created looks correct, but is subtly wrong. $3 isn't the "length" of each segment, it's the template for the output file. $2 is in fact the (approximate) length of each segment in seconds, not the "N" value as the function name suggests. Also, you probably want to set reset_timestamps so the timing information is correct.

  • Deleted

    Permanently Deleted

    Jump
  • Wait, if I make peace with the animals in heaven does that mean I can eat them guilt free now?

  • Deleted

    Permanently Deleted

    Jump
  • I mean, if they don't ask, nobody is going to go out of their way to sign up.

  • Two factor authentication won't help here. You have to build your app with the assumption that any attacker has a valid login and credentials and therefore restrict them to only information they have permission to see.

    File uploads are encrypted in transit from the client to the server but not encrypted on the server.

    Usually when people talk about e2e encrypted messaging they mean that everything is encrypted. That includes images and text content. The server should not be able to read any contents of any message sent through it.

    Again this is a design choice I don’t want gifs.

    Why? Sending memes is a core part of any social media experience.

    There are filetype checks on line 350 of the app.

    Line 350 in both files doesn't seem to contain any filetype checks. I assume you mean file.content_type. That may not be accurate to the actual file uploaded; it can be spoofed.

    Yes deleting is atomic.

     
        
            # Delete the associated message if it exists
            if chat_file.message_id:
                msg = db.get(Message, chat_file.message_id)
                if msg:
                    db.delete(msg)
            ---> Here
            # Delete file from disk
            file_path = os.path.join(CHAT_FILES_DIR, file_uuid)
            if os.path.exists(file_path):
                os.remove(file_path)
    
      

    If the application crashes/closes at the indicated point, then you will delete the message from the database but still have the image on the server. If this is an image served from /img/whatever, it would have no checks beyond a login check.

  • to the extent Tor is secure

    Tor doesn't automatically secure your app. If your social media instance has 1000 users on it, and one user gets compromised, then the other 999 users shouldn't have any interactions outside of that user leaked.

    web crypto can be utilized for group and 1-1s for an additional layer of encryption

    Are file uploads encrypted?

    How would you ever discover a filename?

    Maybe you have a data leak. Maybe they send the filename in plaintext somewhere. Maybe they take advantage of the fact that UUIDs might be deterministic. But if I may flip the question... Why does an inaccessible post even need to return 403 anyway? It just functions as a big footgun that may cause any other exploits to behave worse.

    Even if you have the correct link, if those two conditions arnt satisfied you will not be able to view.

    But you can determine its existence or not through the status code.

    This was a design choice to have consistency in filetypes. What’s the downside? All browsers will support displaying a jpg.

    Gifs will lose any animation, pngs will lose quality. Also, as far as I can tell, there's nothing stopping a malicious user uploading a non-image file.

    Which part are you talking about?

    There are two steps to making a post: Upload and store the image and add the post to the database. There's also similar steps to deleting a post: Removing the image upload and removing the post from the database. Are both these operations atomic?

    Everything except the login page, registration link will behind these two checks see (def login) where the @loginrequired logic is defined for each of the app routes.

    It's not that hard for a sufficiently motivated adversary to get an account on a sufficiently large instance. You need to ensure that one user account being compromised doesn't result in information leakage from unrelated accounts.

    This discussion stems from issues I found in just one function. You're making a product which requires a very high level of security. You need to understand how to write secure code, and your LLM won't be able to do it for you.

    I don't want to discourage you from programming in general, but making a very secure social media site is a rather complex undertaking for someone new to programming.

    1. You list "Activist/journalist secure communication" as a use case. Not all countries have freedom of press.
    2. Looks like you name images based on a random uuid, so that should protect against filename attacks. But if you do have a filename you can tell whether the image has been an image or not.

    Also, looks like all uploads are converted to jpg, regardless as to whether the original image was a jpg (or even an image) or not. Don't do that.

    1. Can you point to where in code this invariant is enforced?
  • Had a quick skim and found this little guy:

     python
        
    # ---------- Protected media route ----------
    @app.route('/img/<path:name>')
    @login_required
    def media(name):
        db = SessionLocal()
        try:
            me = current_user(db)
            # Find the post with this image
            post = db.query(Post).filter_by(image_path=name).first()
            if post:
                # Check visibility
                can_view = post.user_id == me.id or db.query(UserVisibility).filter_by(
                    owner_id=post.user_id, viewer_id=me.id
                ).first() is not None
                if not can_view:
                    abort(403)
            return send_from_directory(UPLOAD_DIR, os.path.basename(name))
        finally:
            db.close()
    
      

    I've not read through everything, but there are some security concerns that jump out to me from just this function. Hopefully you can enlighten me on them.

    Firstly, what is stopping a logged in user from accessing any image that, for whatever reason, doesn't have an associated post for it?

    Secondly, the return codes for "the image doesn't exist" (404) and "the image exists but you can't access it" (403) look to be different. This means that a logged in user can check whether a given filename (e.g. "epstien_and_trump_cuddling.jpg") has been uploaded or not by any user.

    Both of these look to be pretty bad security issues, especially for a project touting its ability to protect from nationstates. Am I missing something?

  • There's tons of backup solutions out there. Why should selfhosters buy a proprietary one?

  • Sad days

    Jump
  • It's easy to get fame as a programmer: Just make a popular open source project and you'll be surrounded by people angry at you for not doing enough upaid work on it.

  • Deleted

    Permanently Deleted

    Jump
  • And then there's the guy whose like "this comic could be two panels shorter!" because timing and pacing is a myth, apparently.

  • "So, you said on social media that you hate this group of people..."

    "Woah, that was like, 10 years ago."

    "Oh, so I take it those aren't representative of your current views then?"

    "... Lets not be too hasty."